[PATCH] D20460: profile] Add support for static counter allocation for value profiling (part-2)

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.
silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.

I have some small cosmetic suggestions but other than that, this looks great!


================
Comment at: lib/profile/InstrProfilingValue.c:111
@@ +110,3 @@
+  if (Node >= EndVNode) {
+    fprintf(stderr, " Warning, running out of nodes: site_%d at func_%" PRIu64
+                    ", value=%" PRIu64 " \n",
----------------
Can you add PROF_WARN in InstrProfilingPort.h to complement PROF_ERR?

Also, a couple wording nitpicks:
- Can we prefix the message with `LLVM Profile: ` like the other messages to clarify for the user where the message comes from.
- Can you say "running out of statically-allocated value profiling nodes" to minimize user confusion.


http://reviews.llvm.org/D20460