[PATCH] D20268: [wip] Resolution-based LTO API.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 16:48:23 PDT 2016


tejohnson added a comment.

Just started to look through the new patch. A high level question - for the distributed backend case, is the idea that clang would invoke LTOBackend:: runThinLtoBackendThread directly, instead of setting up a pass pipeline itself? Were you able to get this patch to work with the clang side distributed backend path?


================
Comment at: include/llvm/LTO/LTO.h:141
@@ +140,3 @@
+
+  /// A combined index hook is called after all module indices have been
+  /// combined. It can be used to implement -save-temps for the combined index.
----------------
joker.eph wrote:
> pcc wrote:
> > joker.eph wrote:
> > > Not sure what "indices" mean in this context.
> > Plural of "module index", but I think I need "indexes" here, since according to https://en.wiktionary.org/wiki/indices this sense of "index" cannot be pluralised as "indices".
> Oh, I see, I don't think we ever named the individual module summaries "index", but only used this term for "combined index". That's why I was confused with what it was referring to.
I think we do use the term index but typically refer to them as per-module indexes. We now have 3 types of indexes:

per-module indexes (emitted by the compile step with the rest of the bitcode)
combined index
individual (combined) indexes (for distributed backends)

Which is admittedly a bit confusing...


http://reviews.llvm.org/D20268





More information about the llvm-commits mailing list