[llvm] r270095 - Remember the relocation model. NFC.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Thu May 19 15:24:24 PDT 2016
Thanks!
Q.
> On May 19, 2016, at 3:16 PM, Rafael EspĂndola <rafael.espindola at gmail.com> wrote:
>
> On 19 May 2016 at 17:18, Quentin Colombet <qcolombet at apple.com> wrote:
>> Hi Rafael,
>>
>> If we want to remember something, I would rather keep a reference on the TargetMachine than copying the RelocModel. (We could build a getRelocModel on top of that reference).
>>
>> The reason why I do not like the RelocModel being copied around is that it is not obvious anymore that the relocation model must be the same for all the sub target involved in a Module.
>
> Fixed in r270147.
>
>
> Cheers,
> Rafael
More information about the llvm-commits
mailing list