[PATCH] D20384: Refactor 1 symbol record
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Thu May 19 12:59:32 PDT 2016
rnk added inline comments.
================
Comment at: include/llvm/DebugInfo/CodeView/SymbolRecord.h:95
@@ +94,3 @@
+
+ uint32_t GetCompressedAnnotation() {
+ if (Annotations.empty())
----------------
Should this really modify the Annotations member variable? Maybe it should be a static method that takes an ArrayRef by non-const reference.
Also, it should be in a .cpp file.
http://reviews.llvm.org/D20384
More information about the llvm-commits
mailing list