[PATCH] D20408: [profile] entry eviction support in value profiler

[Vedant Kumar via llvm-commits]

vsk added inline comments.

================
Comment at: lib/profile/InstrProfilingValue.c:108
@@ -101,3 +107,3 @@
       CurrentVNode->Count++;
       return;
     }
----------------
That makes sense. It might help to add a comment explaining that MinCountVNode is the current eviction candidate (and does not always have the lowest count).

================
Comment at: test/profile/Inputs/instrprof-value-prof-real.c:312
@@ -311,3 +311,3 @@
 // CHECK-NEXT:	[ 0, foo_1_2_2_2_2_2_2_1_2, 747 ]
-// CHECK-NEXT:	[ 0, foo_1_2_2_2_2_2_2_2_1, 746 ]
+// CHECK-NEXT:	[ 0, foo
 // CHECK-NEXT:	[ 1, foo_2_2_2_2_2_2_2_2_2, 2000 ]
----------------
Ah, got it.


http://reviews.llvm.org/D20408