[PATCH] D20406: X86: Don't reset the stack after calls that don't return (PR27117)

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: include/llvm/Target/TargetLowering.h:2525
@@ -2524,1 +2524,3 @@
+          Call.doesNotReturn() ||
+          isa<UnreachableInst>(++Call.getInstruction()->getIterator());
       IsVarArg = FTy->isVarArg();
----------------
rnk wrote:
> Call can be an invoke, in which case it terminates, in which case this may call isa<> on an end iterator, which is bad. I think the easy way to avoid this case is check for !Call.isInvoke() && ....
Instead of `isa<UnreachableInst>(++Call.getInstruction()->getIterator())` you could do `isa<UnreachableInst>(Call.getInstruction()->getNextNode())` which is a little shorter (and simpler IMO).


http://reviews.llvm.org/D20406