[PATCH] D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction

[Jacob Baungard Hansen via llvm-commits]

jacob_hansen added inline comments.

================
Comment at: lib/Target/Sparc/LeonPasses.cpp:23
@@ +22,3 @@
+LEONMachineFunctionPass::LEONMachineFunctionPass(TargetMachine &tm, char& ID) :
+MachineFunctionPass(ID)/*,
+    TM(tm)*/
----------------
remove out-commented code.

================
Comment at: lib/Target/Sparc/LeonPasses.cpp:33
@@ +32,3 @@
+
+//****************************************************************************************************************
+//**** InsertNOPLoad pass
----------------
please limit your lines to 80 columns, there's a few other instances of this.

================
Comment at: lib/Target/Sparc/LeonPasses.cpp:51
@@ +50,3 @@
+
+  //errs() << "InsertNOPLoad on function " << MF.getName() << "\n";
+
----------------
Please remove these out-commented lines of code (or change to debug output), this and on line 60 and 71.

================
Comment at: lib/Target/Sparc/SparcTargetMachine.h:38
@@ +37,3 @@
+  const SparcSubtarget *getSubtarget() const {
+    return &Subtarget;
+  }
----------------
It looks like you may have used an outdated trunk when generating this diff. SparcTargetMachine no longer have a Subtarget member, and the implementation of getSubtargetImpl have changed in the trunk compared to the code here.


Repository:
  rL LLVM

http://reviews.llvm.org/D20353