[PATCH] D20290: [ThinLTO] Refactor ODR resolution and internalization (NFC)

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/LTO/LTO.cpp:90
@@ +89,3 @@
+      if (GlobalValue::isLocalLinkage(S->linkage()))
+        S->setLinkage(GlobalValue::ExternalLinkage);
+    } else {
----------------
tejohnson wrote:
> joker.eph wrote:
> > This does not sound correct to me.
> This is needed so that it is not internalized again in thinLTOInternalizeModule (which runs after promotion).
I see...
The issue is that this function is called *internalize* and is doing *promotion*.


http://reviews.llvm.org/D20290