[PATCH] D20290: [ThinLTO] Refactor ODR resolution and internalization (NFC)

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 08:27:02 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/LTO/LTO.cpp:90
@@ +89,3 @@
+      if (GlobalValue::isLocalLinkage(S->linkage()))
+        S->setLinkage(GlobalValue::ExternalLinkage);
+    } else {
----------------
This does not sound correct to me.


http://reviews.llvm.org/D20290





More information about the llvm-commits mailing list