[PATCH] D19181: Map Attribute in the C API.

[James Y Knight via llvm-commits]

jyknight added a comment.

In http://reviews.llvm.org/D19181#434323, @deadalnix wrote:

> To be able to map the different kind of attribute, one does need to expose LLVMAttributeRef or alike. You proposal doesn't allow for this.


Please explain. The API I proposed does allow access to all three of the kinds of attributes.

> On exposing the AttributeSet, I'd rather avoid exposing something that is not strictly necessary as it may end up evolve in the future. In addition, a ton of code wrap AttributeSet and use setter/getter in the C++ codebase, which should be a sign that this isn't such a great abstraction APIwise.


The last proposal from me had no AttributeSet.


http://reviews.llvm.org/D19181