[PATCH] D20427: [tsan] Don't abort when a deadlock detector finds a mutex cycle longer than 10

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Thu May 19 07:18:42 PDT 2016


dvyukov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_deadlock_detector1.cc:125
@@ +124,3 @@
+  if (len == 0U) {
+    // Hm.. cycle of 10 locks? I'd like to see that.
+    return;
----------------
So, can we see it? :)
Maybe there is just some bug in logic, or a false deadlock report? Is it actually a legit report?
If it is a true report, then we should consider increasing the limit (and then we don't need to remove the CHECK). If it is a false report, then we need to fix something (and again no need to remove the CHECK, let it catch more bugs).


http://reviews.llvm.org/D20427





More information about the llvm-commits mailing list