[patch] Delete Reloc::Default.

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 13:05:00 PDT 2016


Hi Rafael,

This is NFC right? I skimmed through it and it seems that Reloc::Default is handled now by Optional<Reloc::Model>, right?

If I understood this correctly, then LGTM.

Cheers,

-- 
Mehdi


> On May 18, 2016, at 9:35 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
> Having an enum member named Default is quite confusing: Is it distinct
> from the others?
> 
> This patch removes that member and instead uses Optional<Reloc> in
> places where we have a user input that still hasn't been maped to the
> default value, which is now clear has no be one of the remaining 3
> options.
> 
> Cheers,
> Rafael
> <0001-Delete-Reloc-Default.patch>



More information about the llvm-commits mailing list