[PATCH] D20331: [llvm-mc] - Teach llvm-mc to generate compressed debug sections in zlib style.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 12:08:18 PDT 2016


rafael added inline comments.

================
Comment at: lib/MC/MCSectionELF.cpp:162
@@ -161,5 +161,3 @@
 
-bool MCSectionELF::UseCodeAlign() const {
-  return getFlags() & ELF::SHF_EXECINSTR;
-}
+bool MCSectionELF::UseCodeAlign() const { return Flags & ELF::SHF_EXECINSTR; }
 
----------------
grimar wrote:
> davide wrote:
> > Unrelated.
> I am sorry but I find this and above change directly related since that changes are connected to what this patch do.
> But if you think i need to make Flags variable public at first in separate commit, then I have no problems with that, I just think if this whole patch be approved, then I`ll do 2 commits, but otherwise there is probably no need to perform changes with Flags member.
Lets please do this first with just a getter and setter to make the patch easy to read.


http://reviews.llvm.org/D20331





More information about the llvm-commits mailing list