[PATCH] D20019: [PPC] exploitation of new xscmp*, as well as xsmaxcdp and xsmincdp

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 08:03:30 PDT 2016


amehsan added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:473
@@ +472,3 @@
+static bool useP9VSXScalarComparisonInstr(SDNode *N, SelectCCSummary &Summary) {
+
+  if (N->getValueType(0) != MVT::f64 && N->getValueType(0) != MVT::f32)
----------------
nemanjai wrote:
> Would it be appropriate to add an assert that N's opcode is correct (in case in the future this function is called from elsewhere)?
Makes sense. Will do.


http://reviews.llvm.org/D20019





More information about the llvm-commits mailing list