[PATCH] D20304: AMDGPU: Run pointer optimization passes
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Wed May 18 06:37:26 PDT 2016
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:235-236
@@ +234,4 @@
+ // SeparateConstOffsetFromGEP and SLSR creates common expressions which GVN or
+ // EarlyCSE can reuse. GVN generates significantly better code than EarlyCSE
+ // for some of our benchmarks.
+ addEarlyCSEOrGVNPass();
----------------
I would drop this last sentence about bencmarks until we've done our own analysis or instead mentions that it improves some benchmarks with NVPTX.
http://reviews.llvm.org/D20304
More information about the llvm-commits
mailing list