[PATCH] D20361: [LNT] Update timeit.sh to have the same return code as timeit when --append-exitstatus is used

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 05:13:22 PDT 2016


sbaranga created this revision.
sbaranga added a reviewer: jmolloy.
sbaranga added a subscriber: llvm-commits.

When passing --append-exitstatus, timeit will write the exit status
to the output and return 0 (with some exceptions in some edge cases).
The exit status will then be checked as part of the output with fpcmp.

We need timeit.sh to do the same (otherwise we will wrongly record a
failure for some tests).

http://reviews.llvm.org/D20361

Files:
  tools/timeit.sh

Index: tools/timeit.sh
===================================================================
--- tools/timeit.sh
+++ tools/timeit.sh
@@ -39,6 +39,10 @@
 EXITCODE=$?
 if [ "$APPEND_STATUS" = "1" ]; then
   echo "exit $EXITCODE" >> $OUTPUT
+  # When --append-exitstatus is used, timeit will append the
+  # exit status to the output file and return 0. Model this
+  # behaviour here.
+  EXITCODE=0
 fi
 
 echo exit $EXITCODE > $REPORT


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20361.57595.patch
Type: text/x-patch
Size: 431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160518/f3d439ba/attachment-0001.bin>


More information about the llvm-commits mailing list