[patch] Use "new style" stubs on ppc too

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed May 18 04:49:50 PDT 2016


On 18 May 2016 at 06:58, Iain Sandoe <iain at codesourcery.com> wrote:
>
>> On 17 May 2016, at 17:18, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>
>> X86 and ARM switched to using the same section for stubs of hidden and
>> non hidden symbols.
>>
>> This patch does the same for ppc.
>>
>> Cheers,
>> Rafael
>> <t.diff>
>
> Looks like a nice cleanup, it’s just a little hard to be certain of the consequences of the change:
>
> 1. The current behaviour does match what the last gcc-4.2 powerpc toolchain produces.
> 2. Did testing throw anything up? (I somehow doubt it without any runtime-tests)

No. In fact that one test that changes was added by me to show the
difference. It was completely untested.

> 3. If the symbol is visible, then it’s potentially interposed, so I guess the issue is whether the non_lazy_symbol_pointer section is writeable for that purpose, which means that dyld might be the determining factor.  (That it works with x86 [on darwin9?], suggests this is OK).  Probably, the best thing is to try some checks on older systems (will try to do that in the next few days).

Thanks!

Cheers,
Rafael


More information about the llvm-commits mailing list