[PATCH] D20143: New pass: guard widening
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Tue May 17 18:19:04 PDT 2016
chandlerc added a comment.
In http://reviews.llvm.org/D20143#432389, @sanjoy wrote:
> In http://reviews.llvm.org/D20143#432381, @atrick wrote:
>
> > That really is a low threshold :) LLVM likes to use #6 to limit search depth in other places.
>
>
> I'd say it is sufficient for now; I'll bump it a bit higher if needed later, or do something more targeted (e.g. only hoist icmp's and arithmetic, since that's the only bits the rest of the pass can handle).
Personally, I find it odd that you don't want a set as opposed to a limit...
(Peanut gallery comment -- shouldn't impact the progress of the patch)
http://reviews.llvm.org/D20143
More information about the llvm-commits
mailing list