[PATCH] D20342: [codeview] Some cleanup of symbol records

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/SymbolRecord.h:34
@@ +33,3 @@
+/// for reference purposes and when dealing with unknown record types.
+enum SymbolLeafKind : uint16_t {
+#define CV_SYMBOL(name, val) name = val,
----------------
rnk wrote:
> Symbols aren't leafs, though, only type records are referred to as "leafs" in the reference headers. I'd hold off on the "enum class" for SymbolRecordKind for now I guess. Besides, then we won't have two full enumerations.
Nevermind I see why you need two. SymbolKind and SymbolRecordKind sounds good.


http://reviews.llvm.org/D20342