[PATCH] D20260: IR: Introduce local_unnamed_addr attribute.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

You might want to add a case to compatibility.ll too.


================
Comment at: docs/BitCodeFormat.rst:727
@@ -722,2 +726,3 @@
   variable:
+
   * ``not thread local``: code 0
----------------
What are the white space changes? Can you commit them first if it is a cleanup?

================
Comment at: docs/BitCodeFormat.rst:836
@@ -822,1 +835,3 @@
 
+* *threadlocal*: If present, an encoding of the
+  :ref:`thread local property<bcthreadlocal>` of the alias
----------------
Can you commit these first? (they LGTM).

================
Comment at: lib/IR/AsmWriter.cpp:2427
@@ +2426,3 @@
+  case GlobalVariable::UnnamedAddr::Local:
+    Out << "local_unnamed_addr ";
+    break;
----------------
This might look nicer with a function that returns "", "local_unamed_addr " or "unnamed_addr ".


================
Comment at: lib/IR/AsmWriter.cpp:2663
@@ +2662,3 @@
+  case GlobalVariable::UnnamedAddr::Local:
+    Out << " local_unnamed_addr";
+    break;
----------------
That way you get use the helper in here too.


http://reviews.llvm.org/D20260