[PATCH] D20146: [PM] Port DSE to the new pass manager.

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 14:46:07 PDT 2016


Jake VanAdrighem <jvanadrighem at gmail.com> writes:
> On Tue, May 17, 2016 at 1:52 PM, Justin Bogner <mail at justinbogner.com>
> wrote:
>
>> Jake VanAdrighem <jvanadrighem at gmail.com> writes:
>> > JakeVanAdrighem updated this revision to Diff 57399.
>> > JakeVanAdrighem marked an inline comment as done.
>> > JakeVanAdrighem added a comment.
>> >
>> > Rename runOnBasicBlock to eliminateDeadStores. Add an overload that
>> > takes a Function instead of BasicBlock. Made all the helpers
>> > static. Cleaned up function description comments. clang-format.
>> >
>> > I considered discarding this patch and splitting it out but at this
>> > point I'd rather leave it as a slight refactor + port to the new PM.
>>
>> Makes sense. This LGTM.
>>
>> Do you have commit or do you need me to commit this for you?
>>
>>
> I don't have commit access so if you could please commit the patch that
> would be much appreciated. Thank you for taking the time to actually review
> the patches.

Committed in r269847. Thanks!

I noticed before I committed that the new pass wasn't marking the same
analyses preserved as the old one, so I just went ahead and fixed that.


More information about the llvm-commits mailing list