[compiler-rt] r269291 - [sanitizer] Fix a crash when demangling Swift symbols, take 2

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 13:46:02 PDT 2016


Kuba,

Commenting out breaks Darwin builds (because your tests expect it to work).
I'm thing of rolling back all your relevant changes but I'm already looking
at at least 5 CLs chain. Is there any chance you can fix it before I roll
it back and break more in the process?

On Tue, May 17, 2016 at 11:54 AM Kuba Brecka <kuba.brecka at gmail.com> wrote:

> Please revert (or comment out).  Thank you!
>
> Kuba
>
> Sent from my iPhone
>
> On May 17, 2016, at 8:52 PM, Mike Aizatsky <aizatsky at google.com> wrote:
>
> I made a call and decided to comment offending calls rather than rolling
> back the chain:
>
> http://reviews.llvm.org/rL269799
>
> I'm sure Kuba will fix it shortly.  Updating a bug an assigning it to him
> since it requires cleanup. Build should become green shortly.
>
>
> On Tue, May 17, 2016 at 11:49 AM H.J. Lu <hjl.tools at gmail.com> wrote:
>
>> On Tue, May 17, 2016 at 11:31 AM, Mike Aizatsky <aizatsky at google.com>
>> wrote:
>> > I'll roll back the CL since we haven't heard from Kuba for a day.
>> >
>>
>> You also need to roll backs the other 2 commits:
>>
>> Fixup for r269291, which broke the Go TSan build.  Let's not use the
>> symbolizer in Go builds.
>>
>> [sanitizer] Allow nullptr in Swift demangler
>>
>> --
>> H.J.
>>
> --
> Mike
> Sent from phone
>
> --
Mike
Sent from phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160517/5c277547/attachment.html>


More information about the llvm-commits mailing list