[compiler-rt] r269799 - [sanitizers] disabling LateInitialize call to fix the build.

Steven Wu via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 13:27:12 PDT 2016


Hi Mike

Your change breaks the Darwin bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1784/
It seems you are not in the recipients of the failing email. Can you take a look at it?

Thanks

Steven

> On May 17, 2016, at 11:44 AM, Mike Aizatsky via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: aizatsky
> Date: Tue May 17 13:44:21 2016
> New Revision: 269799
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=269799&view=rev
> Log:
> [sanitizers] disabling LateInitialize call to fix the build.
> 
> http://reviews.llvm.org/rL269291 introduced a memory leak.
> Disabling offending call temprorary rather than rolling back the chain
> of CLs.
> 
> Modified:
>    compiler-rt/trunk/lib/asan/asan_rtl.cc
>    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc
> 
> Modified: compiler-rt/trunk/lib/asan/asan_rtl.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/asan/asan_rtl.cc (original)
> +++ compiler-rt/trunk/lib/asan/asan_rtl.cc Tue May 17 13:44:21 2016
> @@ -553,7 +553,8 @@ static void AsanInitInternal() {
> 
>   InitializeSuppressions();
> 
> -  Symbolizer::LateInitialize();
> +  // TODO(kuba) Fix Me.
> +  // Symbolizer::LateInitialize();
> 
>   VReport(1, "AddressSanitizer Init done\n");
> }
> 
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc?rev=269799&r1=269798&r2=269799&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc (original)
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl.cc Tue May 17 13:44:21 2016
> @@ -371,7 +371,8 @@ void Initialize(ThreadState *thr) {
>   ctx->initialized = true;
> 
> #ifndef SANITIZER_GO
> -  Symbolizer::LateInitialize();
> +  // TODO(kuba) Fix Me.
> +  // Symbolizer::LateInitialize();
> #endif
> 
>   if (flags()->stop_on_start) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list