[PATCH] D20331: [llvm-mc] - Teach llvm-mc to generate compressed debug sections in zlib style.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 09:24:56 PDT 2016


rafael added inline comments.

================
Comment at: include/llvm/MC/MCContext.h:388
@@ -387,3 +387,1 @@
 
-    void renameELFSection(MCSectionELF *Section, StringRef Name);
-
----------------
So nice to see this go :-)

================
Comment at: lib/MC/ELFObjectWriter.cpp:1027
@@ +1026,3 @@
+    if (sys::IsLittleEndianHost)
+      sys::swapByteOrder(Size);
+    getStream() << Size;
----------------
So, the size is always written big endian? That is a bit odd, but if that is the case, can you use support::endian::Writer<support::big> instead of the if?


http://reviews.llvm.org/D20331





More information about the llvm-commits mailing list