[PATCH] D20290: [ThinLTO] Refactor ODR resolution and internalization (NFC)

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:536
@@ +535,3 @@
+
+  llvm::internalizeModule(TheModule, MustPreserveGV);
+}
----------------
joker.eph wrote:
> tejohnson wrote:
> > joker.eph wrote:
> > > It it not clear if we still need to use the internalize util, is it temporary? What does it do right now other than iterating over the globals and calling the call-back?
> > Perhaps we could just set the linkage directly for internalized symbols (that's what gold-plugin does for LTO internalization). I was trying to stick closer to the mechanism being used by ThinLTOCodeGenerator.
> Yeah I'm really in favor of moving towards a unified model (i.e. we don't necessarily need the internalize pass, but when I looked at it a few months ago it seemed to me that it was doing some tricky stuff). 
> That said I'm in favor of moving step-by-step and keeping NFC refactoring separated. For this particular case, if the direction is to get rid of it, a FIXME would seem appropriate to me.
Right, it is doing a bunch of checking, so I'd rather not muck with that in this patch. Added a FIXME.


http://reviews.llvm.org/D20290