[PATCH] D20324: [Clang][AVX512][intrinsics] Fix vscalef intrinsics.
Igor Breger via llvm-commits
llvm-commits at lists.llvm.org
Tue May 17 06:15:08 PDT 2016
igorb added a comment.
Please add bug explanation.
I think that instead of scalefIntrin.ll the relevant scalar tests should be moved from avx512f-intrinsics.ll to avx512f-scalar-intrinsics.ll and tested for AVX512F and AVX512F & VL to insure correct result . In general all scalar intrinsics should be tested to catch similar bug.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:21847
@@ -21846,2 +21846,3 @@
case X86ISD::SCALEF: return "X86ISD::SCALEF";
+ case X86ISD::SCALEFS: return "X86ISD::SCALEFS";
case X86ISD::ADDS: return "X86ISD::ADDS";
----------------
please remove space
================
Comment at: lib/Target/X86/X86InstrAVX512.td:3821
@@ -3820,3 +3820,3 @@
}
-defm VSCALEF : avx512_fp_scalef_all<0x2C, 0x2D, "vscalef", X86scalef>, T8PD;
+defm VSCALEF : avx512_fp_scalef_all<0x2C, 0x2D, "vscalef", X86scalef,X86scalefs>, T8PD;
----------------
please add space
http://reviews.llvm.org/D20324
More information about the llvm-commits
mailing list