[PATCH] D18827: Rework/enhance stack coloring data flow analysis.

[Than McIntosh via llvm-commits]

thanm marked 2 inline comments as done.
thanm added a comment.

Will post a revised patch shortly.


================
Comment at: lib/CodeGen/StackColoring.cpp:164
@@ +163,3 @@
+// however, due to the fact that optimizations can sometimes
+// can sometimes migrate uses of a variable outside of its lifetime
+// start/end region. Here is an example:
----------------
wmi wrote:
> repeated "can sometimes"
Fixed.

================
Comment at: lib/CodeGen/StackColoring.cpp:164
@@ +163,3 @@
+// however, due to the fact that optimizations can sometimes
+// can sometimes migrate uses of a variable outside of its lifetime
+// start/end region. Here is an example:
----------------
thanm wrote:
> wmi wrote:
> > repeated "can sometimes"
> Fixed.
Fixed.

================
Comment at: lib/CodeGen/StackColoring.cpp:581
@@ +580,3 @@
+        if (!isStart) {
+          assert(slots.size() == 1);
+          int Slot = slots[0];
----------------
wmi wrote:
> assert message missing.
Fixed


http://reviews.llvm.org/D18827