[PATCH] D20260: [wip] IR: Introduce local_unnamed_addr attribute.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon May 16 09:38:37 PDT 2016


majnemer added inline comments.

================
Comment at: include/llvm/IR/GlobalValue.h:156-160
@@ -155,3 +155,7 @@
 
-  bool hasUnnamedAddr() const { return UnnamedAddr; }
-  void setUnnamedAddr(bool Val) { UnnamedAddr = Val; }
+  enum UnnamedAddrType {
+    NotUnnamedAddr,
+    LocalUnnamedAddr,
+    GlobalUnnamedAddr,
+  };
+
----------------
`NotUnnamedAddr` is a little awkward.

Perhaps it'd be a little easier if we made `UnnamedAddrType` an `enum class`.
Something like:
  enum class UnnamedAddr {
    None,
    Local,
    Global,
  };


http://reviews.llvm.org/D20260





More information about the llvm-commits mailing list