[PATCH] D20186: Move the check of EnablePostRAScheduler to avoid side effect of disabling antidependency breaker

[Mitch Bodart via llvm-commits]

mbodart added inline comments.

================
Comment at: lib/CodeGen/PostRASchedulerList.cpp:296
@@ -290,11 +295,3 @@
   SmallVector<const TargetRegisterClass*, 4> CriticalPathRCs;
-  if (EnablePostRAScheduler.getPosition() > 0) {
-    if (!EnablePostRAScheduler)
-      return false;
-  } else {
-    // Check that post-RA scheduling is enabled for this target.
-    // This may upgrade the AntiDepMode.
-    if (!enablePostRAScheduler(Fn.getSubtarget(), PassConfig->getOptLevel(),
-                               AntiDepMode, CriticalPathRCs))
-      return false;
-  }
+
+  // Check that post-RA scheduling is enabled for this target.
----------------
mgrang wrote:
> You can get rid of the extra newline.
Can you clarify which line is "extra"?

There's one line of white space before, separating the code from some local declarations,
and one after.  Both lead to better readability, IMO.


http://reviews.llvm.org/D20186