[PATCH] D20167: [mips] Compact branch policy control for MIPSR6

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a reviewer: dsanders.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a couple nits


================
Comment at: lib/Target/Mips/MipsDelaySlotFiller.cpp:66-68
@@ +65,5 @@
+enum CompactBranchPolicy {
+  CBNever,
+  CBOptimal,
+  CBAlways
+};
----------------
We should mention that never/always aren't absolute in a doxygen comment.

Also an optional nit: We don't have any rules about it but most enumerators seem to separate the prefix from the name using an underscore (e.g. 'CB_Never')

================
Comment at: test/CodeGen/Mips/compactbranches/compact-branch-policy.ll:13
@@ +12,3 @@
+; ALWAYS: beqzc
+; ALWAYS: nop
+  br i1 %cmp, label %if.then, label %if.end
----------------
Could you add a comment indicating why the ALWAYS case has one?


Repository:
  rL LLVM

http://reviews.llvm.org/D20167