[PATCH] D20252: surface build error content through test event system

[Todd Fiala via llvm-commits]

tfiala marked 4 inline comments as done.
tfiala added a comment.

I think I hit all the comments you indicated with the new patch set.


================
Comment at: packages/Python/lldbsuite/test/test_result.py:145
@@ +144,3 @@
+        exception = err_tuple[1]
+        return type(exception) == build_exception.BuildError
+
----------------
tfiala wrote:
> granata.enrico wrote:
> > I would use isinstance() here
> Okay, I'll have a look at that.  I know None behaves properly with type(), not sure if it does with isinstance().
Yep none works fine here.


http://reviews.llvm.org/D20252