[PATCH] D20215: [AMDGPU] Update nop insertion for debugger usage

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 10:46:46 PDT 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/SIDebuggerInsertNops.cpp:14
@@ -13,2 +13,3 @@
 ///
 /// Tools, such as debugger, need to pause execution based on user input (i.e.
+/// breakpoint). In order to do this, one nop instruction is inserted before the
----------------
Grammar, such as a debugger?

================
Comment at: lib/Target/AMDGPU/SIDebuggerInsertNops.cpp:16
@@ +15,3 @@
+/// breakpoint). In order to do this, one nop instruction is inserted before the
+/// first isa instruction of each high level source statement. Further, debugger
+/// may replace nop instructions with trap instructions based on user input.
----------------
the debugger


http://reviews.llvm.org/D20215





More information about the llvm-commits mailing list