[PATCH] D20084: [sanitizer] Initial implementation of a Hardened Allocator

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 07:55:59 PDT 2016


filcab added inline comments.

================
Comment at: projects/compiler-rt/lib/hardened_allocator/scudo_allocator.cc:135
@@ +134,3 @@
+    __atomic_store(reinterpret_cast<PackedHeader *>(this), &new_packed_header,
+                   __ATOMIC_RELEASE);
+  }
----------------
Yeah, should be nicer. Unless it's a problem due to something I'm not thinking of, then I'd rather have more standard constructs (even though there's no guarantee of an `__int128` type, let alone an `std::atomic<__int128>`, AFAICT libstdc++ and libc++ will have those implemented).


http://reviews.llvm.org/D20084





More information about the llvm-commits mailing list