[PATCH] D17859: [InstCombine] convert 'isPositive' and 'isNegative' vector comparisons to shifts (PR26701, PR26819)

[Sanjay Patel via llvm-commits]

spatel added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:3145-3146
@@ +3144,4 @@
+    // Unlike the scalar case above, we can't rely on any previous
+    // simplification to handle this for us (although it would make sense for
+    // InstSimplify to handle cases with min/max value *splatted* constants).
+    
----------------
chandlerc wrote:
> I'd not have the comment talk about a missing instsimplify pass as we'll likely fail to remove it when adding that...
Good point. I'll replace this with a blurb about the trade-offs that we discussed here. Thanks!


http://reviews.llvm.org/D17859