[PATCH] D18732: [SystemZ] Support LRVH and STRVH opcodes

[Ulrich Weigand via llvm-commits]

uweigand added a comment.

See a couple of inline comments.  Otherwise this looks good ...   Thanks!


================
Comment at: lib/Target/SystemZ/SystemZISelLowering.cpp:4980
@@ +4979,3 @@
+  if (Opcode == ISD::STORE &&
+       cast<StoreSDNode>(N)->isUnindexed() &&
+       !cast<StoreSDNode>(N)->isVolatile() &&
----------------
Why is this check needed?

================
Comment at: lib/Target/SystemZ/SystemZISelLowering.h:318
@@ +317,3 @@
+  // Byte swap store
+  STRV,
+
----------------
Please document the operands of those new ISD codes here.

================
Comment at: lib/Target/SystemZ/SystemZOperators.td:205
@@ +204,3 @@
+def z_storebswap       : SDNode<"SystemZISD::STRV", SDT_ZStoreBSwap,
+                                 [SDNPHasChain, SDNPMayStore]>;
+
----------------
Don't these need the SDNPMemOperand flag as well?


http://reviews.llvm.org/D18732