[PATCH] D20209: [Support/ELF] - Added few constants and structs relative to compressed sections.

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D20209#428622, @emaste wrote:

> You can use http://www.sco.com/developers/gabi/latest/ch4.sheader.html as the canonical reference rather than glibc source


Right. What I really wanted to say is that since "SHF_COMPRESSED intersects with platform specific XCORE_SHF_CP_SECTION," then SHF_COMPRESSED looks to be correct as glibc uses that right now. I am not sure what is XCORE_SHF_CP_SECTION and if it is correct that it has the same value.
llvm-readobj currently parses ELFs with compressed sections like:

    Section {
      Index: 16
      Name: .debug_str (163)
      Type: SHT_PROGBITS (0x1)
      Flags [ (0x830)
        SHF_MERGE (0x10)
        SHF_STRINGS (0x20)
        XCORE_SHF_CP_SECTION (0x800)
      ]
  ...

I think XCORE_SHF_CP_SECTION  should be changed to SHF_COMPRESSED (this patch allows to do that), but I do not yet know will that affect on something that probably uses XCORE_SHF_CP_SECTION. I wonder if "_CP_" means ComPressed either ? Why the 'duplication' of the flag is requred then ?


http://reviews.llvm.org/D20209