[PATCH] D11758: [Unroll] Implement a conservative and monotonically increasing cost tracking system during the full unroll heuristic analysis that avoids counting any instruction cost until that instruction becomes "live" through a side-effect or use outside the...
Sanjoy Das via llvm-commits
llvm-commits at lists.llvm.org
Thu May 12 16:00:05 PDT 2016
sanjoy added a subscriber: sanjoy.
sanjoy added a comment.
Random drive-by comment inline
================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:432
@@ +431,3 @@
+
+ // Can't properly modeal a cost of a call.
+ if(isa<CallInst>(&I))
----------------
chandlerc wrote:
> Maybe leave a FIXME? I feel like we should make some effort to address this in follow-up commits. At the very least I suspect we want to handle intrinsics here.
Nit: spelling
http://reviews.llvm.org/D11758
More information about the llvm-commits
mailing list