[PATCH] D20217: Add direct control of whether or not a symbol is preemtable at runtime

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/AsmParser/LLLexer.cpp:501-502
@@ -500,1 +500,4 @@
 
+  KEYWORD(local);
+  KEYWORD(preemptable);
+
----------------
What do you think about dso_local and dso_preemptable? The code is very clear that this is all about DSO storage, but the langref keywords are a little ambiguous.

================
Comment at: lib/IR/Globals.cpp:44
@@ +43,3 @@
+
+bool GlobalValue::shouldAssumeDSOLocal() const {
+  if (getVisibility() != DefaultVisibility) {
----------------
Some comments would be useful here, the encoding of both local and preemtable in one bit is too clever.

Or we could do as Mehdi suggested and not worry about being so clever. :)


http://reviews.llvm.org/D20217