[PATCH] D19901: [ProfileData] (llvm) Use Error in InstrProf and Coverage

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 12:17:52 PDT 2016


vsk updated this revision to Diff 57086.
vsk marked 2 inline comments as done.
vsk added a comment.

Address David's review feedback.

- EnumBasedError -> ProfErrorInfoBase
- Clean up the log() overrides.
- Minimize the diff (don't change the "success" values, remove a #include of ManagedStatic.h from InstrProf.h)


http://reviews.llvm.org/D19901

Files:
  include/llvm/ProfileData/Coverage/CoverageMapping.h
  include/llvm/ProfileData/Coverage/CoverageMappingReader.h
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfData.inc
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  include/llvm/ProfileData/ProfileCommon.h
  lib/ProfileData/Coverage/CoverageMapping.cpp
  lib/ProfileData/Coverage/CoverageMappingReader.cpp
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  lib/Transforms/Instrumentation/InstrProfiling.cpp
  lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  tools/llvm-cov/CodeCoverage.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/CoverageMappingTest.cpp
  unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19901.57086.patch
Type: text/x-patch
Size: 96932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160512/a992b90e/attachment.bin>


More information about the llvm-commits mailing list