[PATCH] D20190: Get rid of CVLeafTypes.h

[Adrian McCarthy via llvm-commits]

amccarth added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecord.h:1018
@@ +1017,3 @@
+      Methods.emplace_back(L->Type, MethKind, Options, Access, VFTableOffset,
+                           StringRef());
+    }
----------------
My code is a little out of date, so I can't easily look up OneMethodRecord.  What does the empty `StringRef()` argument represent?

================
Comment at: include/llvm/DebugInfo/CodeView/TypeRecords.def:23
@@ -18,1 +22,3 @@
+#ifndef KNOWN_TYPE
+#define KNOWN_TYPE(ename, value, class_name, print_name) LEAF_TYPE(ename, value)
 #endif
----------------
rnk wrote:
> I liked TYPE_RECORD and MEMBER_RECORD better than KNOWN_TYPE and MEMBER_TYPE. MEMBER_TYPES aren't really types, they're records describing class members.
+1 for the old names.


http://reviews.llvm.org/D20190