[PATCH] D20195: [PGO] Add flags to control IRPGO warnings.

Jake VanAdrighem via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 21:45:59 PDT 2016


Great, if possible Sean or David could you commit this for me? I don't have
commit access.

As for your question. Sean and I have actually experienced warnings
resulting from a difference in inlining choices in different TU's but we
will definitely be bringing this up very soon as a separate discussion.
These flags were mostly to deal with `instrprof_error::unknown_function`
which for our use case tends to be pretty spammy but not very helpful.

On Wed, May 11, 2016 at 9:37 PM, David Li <davidxl at google.com> wrote:

> davidxl accepted this revision.
> davidxl added a comment.
> This revision is now accepted and ready to land.
>
> lgtm.
>
> Question : do you get warnings when there is no source change? This
> indicates some potential bugs in compiler. If you see them, can you help
> file bugs?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20195
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160511/719e0e18/attachment.html>


More information about the llvm-commits mailing list