[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

[Wei Mi via llvm-commits]

Ok, I will do that. Thanks to you, Quentin and Eric for the helpful comments!

Wei.

On Wed, May 11, 2016 at 3:09 PM, Matthias Braun <matze at braunis.de> wrote:
> MatzeB accepted this revision.
> MatzeB added a comment.
> This revision is now accepted and ready to land.
>
> In http://reviews.llvm.org/D19884#427795, @wmi wrote:
>
>> > So does the LastInsertPointAnalysis cache depend on the current LiveInterval?
>>
>> >
>>
>> > - If so then we should not make it a member of the analysis class and just pass the liveinterval as a parameter in each query.
>>
>> > - If however the cache does depend on the current interval then we miss a cache clear here when we change the current interval.
>>
>>
>> No, LastInsertPoint cache doesn't depend on current LiveInterval. The
>>  cache only records the two possible insert points of a BB - Before
>>  BB's FirstTerminator, and before the last call if BB has landingpad
>>  successor, which are unrelated with LiveInterval. The cache is used to
>>  accelerate the determination of the final insert point to insert
>>  spill/split for current LiveInterval.
>>
>> Thanks,
>>  Wei.
>
>
> Ok then this patch LGTM.
>
> I would apreciate it, if you could change current live interval to just be passed to the InsertAnalaysis queries instead of being a member in a follow-up commit.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D19884
>
>
>