[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 15:07:34 PDT 2016


> So does the LastInsertPointAnalysis cache depend on the current LiveInterval?
>
> - If so then we should not make it a member of the analysis class and just pass the liveinterval as a parameter in each query.
> - If however the cache does depend on the current interval then we miss a cache clear here when we change the current interval.
>

No, LastInsertPoint cache doesn't depend on current LiveInterval. The
cache only records the two possible insert points of a BB - Before
BB's FirstTerminator, and before the last call if BB has landingpad
successor, which are unrelated with LiveInterval. The cache is used to
accelerate the determination of the final insert point to insert
spill/split for current LiveInterval.

Thanks,
Wei.


More information about the llvm-commits mailing list