[PATCH] D20084: [sanitizer] Initial implementation of a Hardened Allocator

Kostya Kortchinsky via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 14:37:21 PDT 2016


cryptoad added inline comments.

================
Comment at: docs/HardenedAllocator.rst:88
@@ +87,3 @@
+
+Your linked binary should now make use of the Scudo allocation and deallocation
+functions.
----------------
kcc wrote:
> You mean, dynamic linker? 
> Static linker (such as e.g. lld) can safely use it, right? 
I would have to check that.

================
Comment at: projects/compiler-rt/lib/hardened_allocator/scudo_allocator.cc:406
@@ +405,3 @@
+      Printf("ERROR: attempted to size a non-allocated chunk at address %p\n",
+             chunk);
+    }
----------------
vitalybuka wrote:
> no Die?
Good catch!


http://reviews.llvm.org/D20084





More information about the llvm-commits mailing list