[PATCH] D19842: In openFileForRead, attempt to fetch the actual name of the file on disk -- including case -- so that clang can later warn about non-portable #include and #import directives.

Eric Niebler via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 11:40:09 PDT 2016


eric_niebler added a comment.

The only way I know to make `realpath` 100% correct 100% of the time is to `readdir` starting from the drive root, enumerating all the subdirectories to find one that matches the next path component, and recursing all the way up. I think I'm safe in saying that making roughly a bajillion API calls that hit the disk over and over is going to be a lot slower than making just one and hoping for the best. :-)

If you can think of a better way to make this correct 100% of the time on all the platforms LLVM supports, I'm all ears.


http://reviews.llvm.org/D19842





More information about the llvm-commits mailing list