[PATCH] D18898: [Loop Rotation] Make default max rotation header size threshold dependent on target CPU

[Z. Zheng via llvm-commits]

zzheng added a comment.

The patch looks in good shape to me. You can use clang-format to polish indent. See inlined comments.


================
Comment at: lib/Transforms/Scalar/LoopRotation.cpp:588
@@ +587,3 @@
+  bool Changed = iterativelyRotateLoop(
+      &L,
+      UseDefaultMHS ? TTI->getLoopRotationDefaultThreshold() : MaxHeaderSize,
----------------
This indent seems weird, is this the result of clang-format?

================
Comment at: lib/Transforms/Scalar/LoopRotation.cpp:635
@@ +634,3 @@
+    return iterativelyRotateLoop(L, UseDefaultMHS
+                                        ? TTI->getLoopRotationDefaultThreshold()
+                                        : MaxHeaderSize,
----------------
Same indent oddness...


http://reviews.llvm.org/D18898