[PATCH] D20147: [WIP] DebugInfo: New metadata representation for global variables.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 10:07:22 PDT 2016


aprantl added a comment.

Instead of baking a byte-offset into the IR, I was more thinking of using the DIExpression to describe the offset:

For example, to describe a global at offset 4, we would use a DIExpression(DW_OP_constu 4, DW_OP_plus) to adjust the offset.


================
Comment at: test/CodeGen/ARM/2011-08-02-MergedGlobalDbg.ll:1
@@ -1,2 +1,2 @@
 ; RUN: llc -arm-global-merge -global-merge-group-by-use=false -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s
 
----------------
Just a general remark: This should really be split into one test that runs opt -arm-global-merge, and one that runs llc and checks the DWARF output.


http://reviews.llvm.org/D20147





More information about the llvm-commits mailing list