[PATCH] D20156: PR24071 Fix an assert in SelectionDAGBuilder

[Renato Golin via llvm-commits]

rengolin added a comment.

In http://reviews.llvm.org/D20156#427155, @t.p.northover wrote:

> It seems like it would be better to modify llc as you suggest. Adding an explicitly llc test to Clang is almost certainly the wrong thing to do.


Hi Tim,

That's a big change though. I agree llc should have diagnostics, too, but this bug shouldn't remain broken until it does, which can take a while and involve a lot of people.

I don't think having the Clang test is wrong, either. Just that it's better if the test is in the same repo and directly tested. I mean, even having an llc test, doesn't stop us from having a Clang one.

cheers,
--renato


http://reviews.llvm.org/D20156