[PATCH] D20067: Error if inline assembly ends in unexpected mode

Wed May 11 04:45:24 PDT 2016

rovka added a subscriber: rovka.
rovka added a comment.

In http://reviews.llvm.org/D20067#424935, @niravd wrote:

> ARM has a similar situation arise in their code but uses a different fix. There, this situation is fixed if needed if we use the integrated assembler and otherwise always emits a directive in no integrated assembler case. This guarantees any code llvm generates is always correct, but leaves no notification that there is a potential latent bug should you compile with a separate compiler.

I believe this [1] is part of the discussion on the ARM side.

> We should be consistent here and either change ARM to also emit an error or change both to emit warnings.

Changing ARM to emit an error or an on-by-default warning may break builds that didn't break before. Maybe a -Wall warning would be better? How does gcc handle this?

[1] http://reviews.llvm.org/D2255

http://reviews.llvm.org/D20067