[PATCH] D20146: [PM] Port DSE to the new pass manager.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Tue May 10 19:06:25 PDT 2016
davide added a comment.
this looks fine to me, modulo nits.
================
Comment at: include/llvm/Transforms/Scalar/DeadStoreElimination.h:37
@@ +36,3 @@
+
+class DSE : public PassInfoMixin<DSE> {
+public:
----------------
Please add a doxygen comment to explain what this class odes.
================
Comment at: include/llvm/Transforms/Scalar/DeadStoreElimination.h:57
@@ +56,3 @@
+
+ bool runOnBasicBlock(BasicBlock &BB);
+ bool MemoryIsNotModifiedBetween(Instruction *FirstI, Instruction *SecondI);
----------------
I think this should be a FunctionPass instead of a BasicBlockPass?
================
Comment at: lib/Passes/PassRegistry.def:112
@@ -111,2 +111,3 @@
FUNCTION_PASS("dce", DCEPass())
+FUNCTION_PASS("dse", DSE())
FUNCTION_PASS("early-cse", EarlyCSEPass())
----------------
Can you call it DSEPass() for consistency with DCE and others?
Repository:
rL LLVM
http://reviews.llvm.org/D20146
More information about the llvm-commits
mailing list